Fix: Various issue around parent types and sourceProperty in checker and projections #1115

timotheeguerin · 2022-10-03T18:20:00Z

fix #1069

fix #462

packages/compiler/core/projector.ts

azure-pipelines · 2022-10-03T18:30:38Z

You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/1115/

Check the website changes at https://cadlwebsite.z1.web.core.windows.net/prs/1115/

packages/compiler/core/projector.ts

packages/compiler/core/checker.ts

Co-authored-by: Nick Guerrera <nicholg@microsoft.com>

…motheeguerin/cadl into fix/projections-parent-source

packages/samples/test/output/rest/petstore/openapi.json

packages/rest/src/resource.ts

timotheeguerin added 2 commits October 3, 2022 11:14

Fix parent type references

a1d5986

Changelog

42678c6

timotheeguerin requested review from bterlson, daviwil, nguerrera, markcowl and allenjzhang as code owners October 3, 2022 18:20

nguerrera reviewed Oct 3, 2022

View reviewed changes

packages/compiler/core/projector.ts Outdated Show resolved Hide resolved

nguerrera reviewed Oct 3, 2022

View reviewed changes

packages/compiler/core/projector.ts Outdated Show resolved Hide resolved

remove workaround for get effective property type

08ea0b9

nguerrera reviewed Oct 3, 2022

View reviewed changes

packages/compiler/core/checker.ts Outdated Show resolved Hide resolved

timotheeguerin and others added 3 commits October 3, 2022 12:12

Update packages/compiler/core/checker.ts

c38e8df

Co-authored-by: Nick Guerrera <nicholg@microsoft.com>

remove toplevel workaround

2b32f9c

Fix issue with order of execution

3123e7f

nguerrera approved these changes Oct 3, 2022

View reviewed changes

Copy keys point to right model

75c188e

bterlson approved these changes Oct 3, 2022

View reviewed changes

timotheeguerin added 5 commits October 3, 2022 14:45

Fix extracted params

26fe15f

Merge branch 'main' into fix/projections-parent-source

808f957

Merge branch 'fix/projections-parent-source' of https://github.com/ti…

65d1ea7

…motheeguerin/cadl into fix/projections-parent-source

Same for enums

0115c27

Workaround

1b2c898

nguerrera reviewed Oct 3, 2022

View reviewed changes

packages/samples/test/output/rest/petstore/openapi.json Outdated Show resolved Hide resolved

Remove sourceProperty and keep params inline

1c398ec

nguerrera reviewed Oct 3, 2022

View reviewed changes

packages/rest/src/resource.ts Outdated Show resolved Hide resolved

nguerrera approved these changes Oct 3, 2022

View reviewed changes

timotheeguerin mentioned this pull request Oct 3, 2022

OpenAPI emitter deduplicating parameters #1118

Closed

timotheeguerin added 2 commits October 3, 2022 16:10

set sourceproperty to undefined explicitly

a17ebd2

Merge branch 'main' into fix/projections-parent-source

4c69545

timotheeguerin merged commit 2c0cd0b into microsoft:main Oct 4, 2022

timotheeguerin deleted the fix/projections-parent-source branch October 4, 2022 00:10

nguerrera mentioned this pull request Oct 5, 2022

Invalidating sourceProperty on property mutation #1129

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Various issue around parent types and sourceProperty in checker and projections #1115

Fix: Various issue around parent types and sourceProperty in checker and projections #1115

timotheeguerin commented Oct 3, 2022 •

edited

Loading

azure-pipelines bot commented Oct 3, 2022

Fix: Various issue around parent types and sourceProperty in checker and projections #1115

Fix: Various issue around parent types and sourceProperty in checker and projections #1115

Conversation

timotheeguerin commented Oct 3, 2022 • edited Loading

azure-pipelines bot commented Oct 3, 2022

timotheeguerin commented Oct 3, 2022 •

edited

Loading